feat: add a favicon route on the root #17277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might not be the best way to do it, but I couldn't find a clean way to use Pyramid's built-in static handling for a single file. If there's a better way, I'm all for it! |
Many browsers may not respect the inline HTML directive on where to find a favicon file, so add a route to serve it directly and not respond with a 404 Not Found. Refs: #970 Signed-off-by: Mike Fiedler <[email protected]>
|
Seems like Pyramid's recommendation is to do pretty much exactly this: https://docs.pylonsproject.org/projects/pyramid/en/latest/narr/assets.html#registering-a-view-callable-to-serve-a-static-asset |
Signed-off-by: Mike Fiedler <[email protected]>
miketheman
force-pushed
the
miketheman/support-direct-favicon
branch
from
9aa1708 to
c167389
Compare
di
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many browsers may not respect the inline HTML directive on where to find a favicon file, so add a route to serve it directly and not respond with a 404 Not Found.
Refs: #970