Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard our BigQuery release metadata sync against upcoming schema changes #16956

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ewdurbin
Copy link
Member

PEP 639 implementation will need the following columns added to the big query schema:

license_expression, STRING, NULLABLE
license_files, STRING, REPEATED

We'll want that done in advance of merging an implementation, but need to have the Big Query public dataset team do that for us... so to avoid the need for coordination, lets guard ourselves against the schema changing underneath us...

@ewdurbin ewdurbin requested a review from a team as a code owner October 23, 2024 15:37
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, take it or leave it

tests/unit/packaging/test_tasks.py Show resolved Hide resolved
@ewdurbin ewdurbin merged commit be5f770 into main Oct 23, 2024
18 checks passed
@ewdurbin ewdurbin deleted the guard_bigquery_release_metadata_against_new_keys branch October 23, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants