Handle hyphens as post release separators in source distribution filenames #15644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
approved these changes
Mar 20, 2024
javanlacerda
pushed a commit
to javanlacerda/warehouse
that referenced
this pull request
Mar 25, 2024
…names (pypi#15644) * Add a failing test * Permit hyphens as a post-release separator for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have an edge case where we're not permitting source distribution filenames that use a hyphen as a post-release separator. This creates a confusing error message for users, as detailed in #14763 (comment).
Until we land #12245 and support PEP 625, we should permit them IFF the version in the filename exactly matches the provided version (otherwise, it's impossible to extract from the filename).