-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document additional Trusted Publishers #15192
Conversation
Signed-off-by: William Woodruff <[email protected]>
* Google Trusted Publishing docs * Update docs/user/trusted-publishers/security-model.md Co-authored-by: Facundo Tuesca <[email protected]> * Update docs/user/trusted-publishers/security-model.md Co-authored-by: Facundo Tuesca <[email protected]> * Apply suggestions from code review Co-authored-by: William Woodruff <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Facundo Tuesca <[email protected]> Co-authored-by: William Woodruff <[email protected]>
OK, I think the Google docs are good here. FYI, what I'm doing to keep the screenshots consistent is going to the sections I added in #15193 in the Chrome inspector, right clicking and doing "Capture node screenshot". Looking at the docs now, we might want to add some padding & a border around screenshots, because in light mode they look a lot like out docs text, and in dark mode there isn't enough padding. |
ActiveState has fully landed as well, so we need a PR against this branch for its docs (cc @th3coop) |
Hey @th3coop, friendly ping here to see if you'll be able to add the ActiveState docs! |
* Add GitLab Trusted Publishing docs * Add screenshots to GitLab Trusted Publishing docs * Fix instructions for GitLab CI with Trusted Publishing
Hey @di! Someone is working on a PR for this right now. Possibly ready today, more likely next week. Is that timing ok? I'm coordinating with PeteG btw. |
Sure that works! Our goal is to have this launched by PyCon US at the very latest, but ideally sooner. |
Sounds good. Thanks for the heads up @di! |
@di or @woodruffw, could either of you update this branch with master to get the ActiveState OIDC code into the branch? |
@th3coop Done! |
* First draft of ActiveState Trusted Publishing docs * Add ActiveState Security Model and Considerations * Adding examples * Add link to ActiveState hosted OIDC docs * Add updated docs from Andrew * MD tweaks and some images * Add remaining screenshots and embbed them in MD * Tweaking instructions for publishing * Update warehouse/templates/manage/account/publishing.html Co-authored-by: William Woodruff <[email protected]> * Review edit Co-authored-by: Dustin Ingram <[email protected]> * Review edits Co-authored-by: Dustin Ingram <[email protected]> * Review edits Co-authored-by: Dustin Ingram <[email protected]> * Review edits Co-authored-by: Dustin Ingram <[email protected]> * Review edits Co-authored-by: Dustin Ingram <[email protected]> * Translations * Fix build script tokens, link to supported platforms * Revise and reformat ActiveState using instructions --------- Co-authored-by: Pete Garcin <[email protected]> Co-authored-by: William Woodruff <[email protected]> Co-authored-by: Dustin Ingram <[email protected]>
* Fix old byline * Add blogpost announcing more trusted publishers * Update docs/blog/posts/2024-04-20-expanding-trusted-publisher-support.md Co-authored-by: Mike Fiedler <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Mike Fiedler <[email protected]>
* Updating ActiveState publishing docs * Update docs/user/trusted-publishers/using-a-publisher.md Co-authored-by: Dustin Ingram <[email protected]> --------- Co-authored-by: Dustin Ingram <[email protected]>
@pypi/warehouse-committers This is ready for review, with an anticipated publish date of Monday, April 15th! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed some of the instructions, but generally looks good. I dropped a fair amount of notes, feel free to accept/reject them as needed for this rollout.
docs/user/assets/trusted-publishing/activestate/pending-publisher-registered.png
Outdated
Show resolved
Hide resolved
docs/user/trusted-publishers/creating-a-project-through-oidc.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed some of the instructions, but generally looks good. I dropped a fair amount of notes, feel free to accept/reject them as needed for this rollout.
* Fix ActiveState getting started Trusted Publisher links * REALLY fix ActiveState getting started Trusted Publisher links
(recreating #15179 as a branch on this repo so we can make PRs against it here)
These sections are all empty for now; we'll fill them out as we complete each Trusted Publisher's provider implementation.
Trackers:
With each of these, the following is needed for their documentation: