Skip to content

Commit

Permalink
continue on PR template (setup)
Browse files Browse the repository at this point in the history
  • Loading branch information
mara004 committed Nov 27, 2023
1 parent e26b24d commit 0822682
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@
- Use the Preview tab to confirm the PR will render correctly.
-->

### Setup

- [ ] This PR changes setup code (`setupsrc/`, `setup.py` etc.).
- [ ] I have tested the change does not break internal callers.
- [ ] I believe the change is maintainable and does not cause unreasonable complexity or code pollution.
- [ ] If acting on behalf of a downstream use case, I have assessed that it cannot reasonably be solved by existing means, or the change forms a notable improvement over possible alternatives.
- [ ] I believe the targeted use case is supported by pypdfium2-team. *Note that we may not want to support esoteric or artificially restricted setup envs.*

### Helpers

- [ ] This PR changes helpers code.
Expand All @@ -30,3 +22,12 @@
### Other

- [ ] This PR changes other things, namely: ... <!-- briefly specify what was changed -->

### Setup

- [ ] This PR changes setup code (`setupsrc/`, `setup.py` etc.).
- [ ] I have tested the change does not break internal callers.
- [ ] I believe the change is maintainable and does not cause unreasonable complexity or code pollution.
- [ ] This does not try to shift a maintenance burden or upstream things that should be handled downstream. *Keep handlers generic, avoid overly downstream-specific or effectively dead code passages.*
- [ ] I have assessed that the targeted use case cannot reasonably be satisfied by existing means, or the change forms a notable improvement over possible alternatives.
- [ ] I believe the targeted use case is supported by pypdfium2-team. *Note that we may not want to support esoteric or artificially restricted setup envs.*

0 comments on commit 0822682

Please sign in to comment.