refactor to not do too much in ReentrantFileLock.__del__ #2213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint
)docs/changelog
folderInternal refactor of
ReentrantFileLock.__del__
to avoid the_store_lock
context if not needed. Also make sure the lock is deleted and set to None in the__exit__
call, so that__del__
now will be a no-op on the happy path.This came up in #2206 when looking at PyPy failures. Since PyPy uses a non-refcount garbage collector,
__del__
can be called much later than on CPython, leaving unneeded locks hanging around.