-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
In deprecated setup.py install, fall back to distutils. #4970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5776482
to
6d4e4c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The fix itself seems to work.
However, I have some remarks about the non-fix parts of this PR.
8da58cb
to
7fc5e05
Compare
# TODO: Document how to bootstrap setuptools without install | ||
# (e.g. by unzipping the wheel file) | ||
# and then add a due_date to this warning. | ||
due_date=(2025, 10, 31), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not a lot of time. I maintain a build-system depending on this, and I know there are a lot of others. I don't think 6 months is enough time to change them.
The system I care about is Debian's Python Package toolchain (dh-python
). We implemented pypa/installer
in it in late 2021, and many packages have been migrated across (but almost certainly only the easy ones). It's been on my todo list to look into pushing the rest over, but there hadn't been any urgency. I thought the setup.py install
interface was too entrenched everywhere to be deprecated at short notice like this.
In practice, with our current release freeze, I can't even look at starting making large-scale changes to do anything about this, in the next 6 months.
Instead of failing when easy_install isn't present. Closes #3143
Summary of changes
Closes #3143
Pull Request Checklist
newsfragments/
.(See documentation for details)