Remove existing package before develop mode install #3875
Closed
+44
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools has changed its default behaviour whe installing packages installed in "develop mode" (i.e. pip -e) from being inserted first in sys.path to being added last (for details, see the bug). This means that if "pip install -e" a git tree to work on something but have the original package installed from PyPi (etc.), you will not actually be importing the development version. During interactive development you'll probably notice that your changes aren't applying and start digging around, but this behaviour change could be very bad in a CI situation where you *think* you've installed a development version but really, with setuptools>=25, you're just testing the release version. This change removes an existing install before deploying in develop mode. This way we only have one copy of the package and avoid ordering issues. A new test is added. Fixes pypa#3874
| path = local_repo( | ||
| 'git+http://github.com/pypa/pip-test-package.git', | ||
| tmpdir.join("cache"), | ||
| ) |
There was a problem hiding this comment.
I'd rather not have a network related test if we can avoid it.
You could use an existing module like https://github.com/pypa/pip/blob/6dc28c1/tests/data/src/singlemodule#L799-L805
Then:
- install it via its path
- install it via editable
- check that pip freeze/list report it as editable
- uninstall it
- check that all installation disappeared
|
I don't like the approach used, I think we should stick with |
|
Implemented in #3898 |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools has changed its default behaviour whe installing packages
installed in "develop mode" (i.e. pip -e) from being inserted first in
sys.path to being added last (for details, see the bug).
This means that if "pip install -e" a git tree to work on something
but have the original package installed from PyPi (etc.), you will not
actually be importing the development version. During interactive
development you'll probably notice that your changes aren't applying
and start digging around, but this behaviour change could be very bad
in a CI situation where you think you've installed a development
version but really, with setuptools>=25, you're just testing the
release version.
This change removes an existing install before deploying in develop
mode. This way we only have one copy of the package and avoid
ordering issues. A new test is added.
Fixes #3874