-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement --recorded-root, fixes #1351 #2117
Conversation
How important is this to you for 6.0 @bkabrda? I ask because I think I might prefer switching this around and behaving more like a traditional |
To be specific, I ask because I'm trying to prioritize whether to get something in or wait until we can get it just right. |
Well, for our packaging use we can always include this as a downstream patch (we do now). So it's not absolutely necessary (although it's always nice to not diverge from upstream, so accepting this would be appreciated :)). |
ok! |
Accidentally closed this, reopening. Sorry! |
Hello! As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged. If this pull request is still valid, please rebase it against If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:
|
This Pull Request was closed because it cannot be automatically reparented to the Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto |
A --recorded-root install argument as discussed in #1351.