Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --recorded-root, fixes #1351 #2117

Closed
wants to merge 1 commit into from
Closed

Implement --recorded-root, fixes #1351 #2117

wants to merge 1 commit into from

Conversation

bkabrda
Copy link

@bkabrda bkabrda commented Nov 5, 2014

A --recorded-root install argument as discussed in #1351.

@dstufft
Copy link
Member

dstufft commented Dec 18, 2014

How important is this to you for 6.0 @bkabrda?

I ask because I think I might prefer switching this around and behaving more like a traditional Makefile where you do something like pip install --prefix /usr/ --destination /tmp/dir or something like that.

@dstufft
Copy link
Member

dstufft commented Dec 18, 2014

To be specific, I ask because I'm trying to prioritize whether to get something in or wait until we can get it just right.

@bkabrda
Copy link
Author

bkabrda commented Dec 18, 2014

Well, for our packaging use we can always include this as a downstream patch (we do now). So it's not absolutely necessary (although it's always nice to not diverge from upstream, so accepting this would be appreciated :)).

@dstufft
Copy link
Member

dstufft commented Dec 18, 2014

ok!

@dstufft
Copy link
Member

dstufft commented May 18, 2016

Accidentally closed this, reopening. Sorry!

@dstufft dstufft reopened this May 18, 2016
@BrownTruck
Copy link
Contributor

Hello!

As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the master branch. However, this Pull Request was made against the develop branch so it will need to be resubmitted against master. Unfortunately, this pull request does not cleanly merge against the current master branch.

If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged.

If this pull request is still valid, please rebase it against master (or merge master into it) and resubmit it against the master branch, closing and referencing the original Pull Request.

If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:

A --recorded-root install argument as discussed in #1351.

---

*This was migrated from pypa/pip#2117 to reparent it to the ``master`` branch. Please see original pull request for any previous discussion.*

@BrownTruck BrownTruck added asked to reparent auto-bitrotten PRs that died because they weren't updated and removed asked to reparent labels May 19, 2016
@BrownTruck
Copy link
Contributor

This Pull Request was closed because it cannot be automatically reparented to the master branch and it appears to have bit rotted.

Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto master or merged master into it.

@BrownTruck BrownTruck closed this May 26, 2016
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-bitrotten PRs that died because they weren't updated auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants