Skip to content

DRY tomllib compatibility #13370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/pip/_internal/pyproject.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,16 @@
import importlib.util
import os
import sys
from collections import namedtuple
from typing import Any, List, Optional

if sys.version_info >= (3, 11):
import tomllib
else:
from pip._vendor import tomli as tomllib

from pip._vendor.packaging.requirements import InvalidRequirement

from pip._internal.exceptions import (
InstallationError,
InvalidPyProjectBuildRequires,
MissingPyProjectBuildRequires,
)
from pip._internal.utils.compat import tomllib
from pip._internal.utils.packaging import get_requirement


Expand Down
7 changes: 1 addition & 6 deletions src/pip/_internal/req/req_dependency_group.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
import sys
from typing import Any, Dict, Iterable, Iterator, List, Tuple

if sys.version_info >= (3, 11):
import tomllib
else:
from pip._vendor import tomli as tomllib

from pip._vendor.dependency_groups import DependencyGroupResolver

from pip._internal.exceptions import InstallationError
from pip._internal.utils.compat import tomllib


def parse_dependency_groups(groups: List[Tuple[str, str]]) -> List[str]:
Expand Down
8 changes: 7 additions & 1 deletion src/pip/_internal/utils/compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import sys
from typing import IO

__all__ = ["get_path_uid", "stdlib_pkgs", "WINDOWS"]
__all__ = ["get_path_uid", "stdlib_pkgs", "tomllib", "WINDOWS"]


logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -67,6 +67,12 @@ def open_text_resource(
)


if sys.version_info >= (3, 11):
import tomllib
else:
from pip._vendor import tomli as tomllib


# packages in the stdlib that may have installation metadata, but should not be
# considered 'installed'. this theoretically could be determined based on
# dist.location (py27:`sysconfig.get_paths()['stdlib']`,
Expand Down
7 changes: 1 addition & 6 deletions tests/functional/test_lock.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
import sys
import textwrap
from pathlib import Path

from pip._internal.utils.compat import tomllib
from pip._internal.utils.urls import path_to_url

from ..lib import PipTestEnvironment, TestData

if sys.version_info >= (3, 11):
import tomllib
else:
from pip._vendor import tomli as tomllib


def test_lock_wheel_from_findlinks(
script: PipTestEnvironment, shared_data: TestData, tmp_path: Path
Expand Down