Improve and migrate editable errors to diagnostic format #12811
Closed
+79
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
force-pushed
the
errors/editable-mode-take-2
branch
from
0d43de0 to
890b185
Compare
ichard26
force-pushed
the
errors/editable-mode-take-2
branch
from
890b185 to
24ac827
Compare
|
Hmm. I've come to learn that the editable requirement syntax is poorly defined (see #12745). I'll re-review this PR in light of that tomorrow. |
|
I'll revisit this at some later time. I'm going to subsume the editable install unsupported by your backend error into my legacy editable removal PR, and the other error needs some more investigation before being improved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #10421. ✨
This is a significantly retooled version of #12464. I further reworded the errors to be more friendly and less technical.
Before
After