Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with absolute path with Python 3.13 on Windows #302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue with absolute path with Python 3.13 on Windows #302

wants to merge 1 commit into from

Commits on Oct 21, 2024

  1. Fix issue with absolute path with Python 3.13 on Windows 

    With Python 3.13 on Windows, `os.path.isabs()` no longer returns `True`
for a path that starts with a slash. Thus, when the argument to
`_make_relative()` is an absolute path, the return value starts with a
slash on Python 3.13 and does not start with a slash on older Python
versions. This causes the extension module build directory to be
calculated incorrectly with Python 3.13 on Windows.

Fix this by ensuring that the return value does not start with a slash.
    @adang1345
    adang1345 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    464735f View commit details
    Browse the repository at this point in the history