CMSIS-DAP: hidapi backend improvement; protocol version fixes; more trace logging #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Log v1/v2 based on use of bulk endpoints, so it’s easy to see in a debug log. - Explicit check for beta versions. - Only compare against major protocol versions. - Reintroduce explicit handling of DAPLink 0254 and 0255 so they are recognised as v2.x. - Output debug log if an unknown major version is found or there is an error parsing. - Set fallback protocol version based on bulk endpoint usage.
- _Command objects have unique IDs, output in trace logs. - Trace logging of _read_packet(), _send_packet(), and aborts. - Renamed _Command._get_free_words() to _get_free_transfers() to reflect actual return value.
|
This pull request introduces 3 alerts when merging 25c9e4d into 3a4e837 - view on LGTM.com new alerts:
|
|
The AZP tests are failing to download a |
… limit. This change introduces a background read thread for the HidApiUSB backend for CMSIS-DAP. Similar to the other backends, it reads and queues incoming command responses as soon as they are available. Also added a packet count maximum to deal with the arbitrary limit of 30 queued IN reports in the Mac version of hidapi.
flit
force-pushed
the
feature/more_cmsis_dap_trace_logging
branch
from
25c9e4d
to
bddbd19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two major, connected components to this PR, all focused on the CMSIS-DAP implementation.
The first component is some fixes/improvements:
The second component improves CMSIS-DAP trace logging and test features:
-Lpyocd.probe.pydapaccess.interface.*backend.trace=debug.dap_access_cmsis_dap.py). Enabled with-Lpyocd.probe.pydapaccess.dap_access_cmsis_dap.trace=debug.cmsis_dap.prefer_v1session option to force selection of v1 if a probe provides both v1 and v2 interfaces. Naturally, v2 is and always has been, used by default.There are also some minor changes to go along with the above.
Thanks to @afeinman-snap for the bug report that drove these changes, and he and @bohdan-tymkiv for help solving it!
Fixes #1257.