Support linking with yt #224
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
force-pushed
the
support-xlink-yt
branch
from
b91e153
to
5988dd5
Compare
|
I have merged in the deprecation of python 3.7, so if you merge the master branch in here you will get more meaningful test results. |
cphyc
force-pushed
the
support-xlink-yt
branch
from
0548e89
to
0a02ccd
Compare
tangos is numbering from 0 onwards, while yt is using the rockstar ids in some random but deterministic (?) order.
cphyc
force-pushed
the
support-xlink-yt
branch
from
bba7094
to
8f7a801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with yt-project/yt#4661, this adds the possibility to link rockstar datasets loaded through yt.