Replace pixmap color inversion logic #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use our own code for this - which is erroneous and also is very slow (written in Python). This fix falls back to using MuPDF native functions fz_invert_pixmap and fz_invert_pixmap_rect. This obsoletes function "JM_invert_pixmap_rect" and significantly improves speed.
julian-smith-artifex-com
approved these changes
Jan 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using our own code for this - which is erroneous and also is very slow (written in Python). This fix falls back to using MuPDF native functions
fz_invert_pixmapandfz_invert_pixmap_rect. This obsoletes functionJM_invert_pixmap_rectand significantly improves speed.