Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dependency on the py module during pip installation #250

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

ptpan
Copy link
Contributor

@ptpan ptpan commented Nov 2, 2023

This pull request adds the py module to the dependency of pymtl3 to fix errors after pip install pymtl3

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0244456) 89.18% compared to head (fde62dd) 88.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   89.18%   88.86%   -0.32%     
==========================================
  Files         330      330              
  Lines       30440    30440              
==========================================
- Hits        27147    27052      -95     
- Misses       3293     3388      +95     
Files Coverage Δ
pymtl3/version.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptpan ptpan merged commit 06466bf into master Nov 2, 2023
4 of 6 checks passed
@ptpan ptpan deleted the pp482-py-dependency-fix branch November 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant