Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/replace traktor with pytrakt #8916

Merged
merged 34 commits into from
Jan 3, 2021

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Dec 24, 2020

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Goal of this PR is to fully replace traktor, because:

  • PyTrakt is python2/3 compatible.
  • PyTrakt support oauth (device auth)
  • Is an official pypi released package.

TODO

  • authentication
  • recommended shows
  • notifications
  • all the sync watchlist / collection stuff

/home/requestTraktDeviceCodeOauth (request a new device authentication)
/home/checkTrakTokenOauth (verify if the request has been authorized by the user)
…tions/trakt_recommendations.py

* Added get_collection, get_watched, collected_shows, watched_shows, played_shows, anticipated_shows to pytrakt lib.
*
# Conflicts:
#	medusa/server/web/home/add_shows.py
#	medusa/server/web/home/handler.py
#	medusa/show/recommendations/trakt_recommendations.py
#	themes-default/slim/views/config_notifications.mako
…place-traktor-with-pytrakt

# Conflicts:
#	medusa/app.py
#	medusa/show/recommendations/trakt_recommendations.py
#	themes-default/slim/views/config_notifications.mako
#	themes/dark/templates/config_notifications.mako
#	themes/light/templates/config_notifications.mako
* Fixed testTrakt button.
* Fixed test blacklist.
* Added property for status.
* Added trakt sync to the episode.status setter.

Now the Api set's status and a request to trakt is considered.
But other calls, won't trigger trakt api calls.
@p0psicles
Copy link
Contributor Author

stuck on moogar0880/PyTrakt#132

@p0psicles
Copy link
Contributor Author

@medariox I forgot, I still want to add some exception handling. After that, it can be merged.

@p0psicles p0psicles merged commit 5f1b419 into develop Jan 3, 2021
@p0psicles p0psicles deleted the feature/replace-traktor-with-pytrakt branch January 3, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants