Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locking actor #84

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Add locking actor #84

merged 9 commits into from
Jun 19, 2024

Conversation

BenediktBurger
Copy link
Member

@BenediktBurger BenediktBurger commented Jun 1, 2024

Closes #39

Uses the message added in #82 (adaptations needed, once that is merged!)

@BenediktBurger BenediktBurger added the enhancement New feature or request label Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (cc496b7) to head (e0890c2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   89.37%   89.58%   +0.20%     
==========================================
  Files          36       38       +2     
  Lines        2937     2996      +59     
  Branches      363      371       +8     
==========================================
+ Hits         2625     2684      +59     
  Misses        261      261              
  Partials       51       51              
Flag Coverage Δ
unittests 89.58% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger BenediktBurger marked this pull request as ready for review June 1, 2024 11:00
@BenediktBurger
Copy link
Member Author

The temporary storage of the last message is based on the usage in #82 .
If both PRs are merged, the process_json_message change and the definition of current_message should be removed.

@BenediktBurger BenediktBurger merged commit 560e5d7 into main Jun 19, 2024
20 checks passed
@BenediktBurger BenediktBurger deleted the locking_actor branch June 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add locking actor (and corresponding director)
1 participant