Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data_logger timer #70

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Fix data_logger timer #70

merged 4 commits into from
Apr 12, 2024

Conversation

BenediktBurger
Copy link
Member

@BenediktBurger BenediktBurger commented Apr 9, 2024

Fixes bugs:

  • If you set the trigger to the timer and a timeout, the timer is started before the timeout value is updated, therefore the timer uses the previous timeout value.
  • There was no lock around the lists, therefore, while saving a file, the timed trigger (executed in another thread) could add elements to list, enlarging some of the lists, but not all.

This PR modifies the tests to show this scenario (first issue) and fixes the problem.

@BenediktBurger BenediktBurger added the bug Something isn't working label Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (0ce18cf) to head (5238d1c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   87.60%   87.58%   -0.03%     
==========================================
  Files          36       36              
  Lines        2888     2899      +11     
  Branches      348      355       +7     
==========================================
+ Hits         2530     2539       +9     
- Misses        298      300       +2     
  Partials       60       60              
Flag Coverage Δ
unittests 87.58% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger BenediktBurger merged commit a4ee43b into main Apr 12, 2024
20 checks passed
@BenediktBurger BenediktBurger deleted the fix-data-logger branch April 12, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant