Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coordinator to not use period in hostname as namespace #69

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

BenediktBurger
Copy link
Member

Coordinator did turn the full hostname (including periods, for example "hostname.domain.tld") into the namespace.
A namespace must not contain periods.
This PR adds tests (which failed even where gethostname returns just the last name) and a fix covered by these tests.

@BenediktBurger BenediktBurger added the bug Something isn't working label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (646ccfd) to head (6867ff6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files          36       36           
  Lines        2888     2888           
  Branches      348      348           
=======================================
  Hits         2530     2530           
  Misses        298      298           
  Partials       60       60           
Flag Coverage Δ
unittests 87.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger BenediktBurger merged commit 0ce18cf into main Mar 27, 2024
20 checks passed
@BenediktBurger BenediktBurger deleted the fix-coordinator-hostname branch March 27, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant