-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove json dependency #63
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 87.28% 87.63% +0.35%
==========================================
Files 33 36 +3
Lines 2626 2846 +220
Branches 314 343 +29
==========================================
+ Hits 2292 2494 +202
- Misses 280 293 +13
- Partials 54 59 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
67ade32
to
b2f3747
Compare
Working for a week in the lab. |
A few thoughts from skimming the PR:
|
Thanks for your comments
The idea was, to include pyleco into pymodaq, which supports python 3.8 and @seb5g mentioned, that he would like to use it on an old system, which only allows python 3.7. However, I noticed, that python 3.7 is not achievable in #61 , so I dropped that idea.
This PR is the first one of two, which adds objects. The second one (#64 ) with more changes, changes also that requirement.
Especially as it is not as complete as the imported code. |
These two dependencies can be written in two small files, which enables us to support older versions of Python than the dependencies allow.
RPCServer
for use in Python<3.9 instead of the version ofopenrpc
package.This self written version does not yet support fully openrpc creation of method description, therefore it is good to keep openrpc as a dependency for those python versions, where it is available.
Closes #5