Refactor Director.ask_message

pyleco/directors/director.py

@@ -88,10 +88,9 @@ def __exit__(self, exc_type, exc_value, exc_traceback) -> None:
     # Message handling
     def ask_message(self, actor: Optional[Union[bytes, str]] = None,
                     data: Optional[Any] = None, **kwargs) -> Message:
-        cid0 = generate_conversation_id()
         actor = self._actor_check(actor)
         log.debug(f"Asking {actor!r} with message '{data}'.")
-        response = self.communicator.ask(actor, conversation_id=cid0, data=data, **kwargs)
+        response = self.communicator.ask(actor, data=data, **kwargs)
         log.debug(f"Data '{response.data}' received.")
         return response
 

tests/directors/test_director.py

@@ -77,6 +77,19 @@ def test_default_actor(self, director: Director):
         assert director._actor_check("") == "actor"
 
 
+def test_ask_message(director: Director):
+    rec = Message("director", "actor", conversation_id=cid)
+    director.communicator._r = [rec]  # type: ignore
+    result = director.ask_message()
+    assert result == rec
+    sent = director.communicator._s[0]  # type: ignore
+    assert sent == Message(
+        "actor",
+        "director",
+        conversation_id=cid,
+    )
+
+
 def test_get_rpc_capabilities(director: Director):
     data = {"name": "actor", "methods": []}
     director.communicator._r = [  # type: ignore