Skip to content

Migrate to prior module from pymc-extras #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented Jun 16, 2025

Description

Adding the dependency of pymc-extras to use the prior module from there

Related Issue

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1767.org.readthedocs.build/en/1767/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation CLV customer choice Related to customer choice module Bass model Dealing with the Bass Defusion model labels Jun 16, 2025
@williambdean williambdean added deprecation and removed docs Improvements or additions to documentation CLV customer choice Related to customer choice module Bass model Dealing with the Bass Defusion model labels Jun 16, 2025
@github-actions github-actions bot added docs Improvements or additions to documentation CLV customer choice Related to customer choice module Bass model Dealing with the Bass Defusion model labels Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.78%. Comparing base (893a7f2) to head (d6e89a9).

Files with missing lines Patch % Lines
pymc_marketing/deserialize.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
- Coverage   92.07%   91.78%   -0.30%     
==========================================
  Files          62       62              
  Lines        7398     7025     -373     
==========================================
- Hits         6812     6448     -364     
+ Misses        586      577       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@williambdean williambdean requested review from cetagostini and juanitorduz and removed request for cetagostini June 16, 2025 22:54
@juanitorduz
Copy link
Collaborator

Looks great, but some tests are failing . . .

@williambdean
Copy link
Contributor Author

williambdean commented Jun 17, 2025

Dropping support for python 3.10 ...
Related with pymc-extras PR pymc-devs/pymc-extras#497
https://scientific-python.org/specs/spec-0000/

@williambdean
Copy link
Contributor Author

williambdean commented Jun 18, 2025

TODO :

  • Need to check for backwards compat imports but with warnings
  • Remove any references in the documentation / redirect

@williambdean
Copy link
Contributor Author

williambdean commented Jun 19, 2025

I've done some explicit deprecation warnings upon initialization of the public objects if imported from pymc_marketing.prior.

I fear running into the issue like with #1540 if trying to raise upon import

Let me know if this is sufficient. CC: @daniel-saunders-phil @juanitorduz

@juanitorduz
Copy link
Collaborator

Shall we add depreciation warnings in 0.15 and remove it entirely in 0.16 ? (or is this already what will happen?)

@ColtAllen
Copy link
Collaborator

Shall we add depreciation warnings in 0.15 and remove it entirely in 0.16 ? (or is this already what will happen?)

We should also update the dev environment.yml, though maybe not in this PR. Minimum dependency requirements are out of sync with the library.

@williambdean
Copy link
Contributor Author

There are deprecation warning with this PR. They will be removed in future release resulting in attribute errors

@juanitorduz
Copy link
Collaborator

I have also seen people use pymc-marketing in Databricks clusters with python 3.10 :/ . I wonder if this will have an impact in a lot of users.

@williambdean
Copy link
Contributor Author

Likely. We should do minor release and put top of release notes

@williambdean williambdean added the major API breaking changes label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bass model Dealing with the Bass Defusion model CLV customer choice Related to customer choice module deprecation docs Improvements or additions to documentation maintenance major API breaking changes MMM Prior class tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Prior class from pymc-extras
3 participants