-
Notifications
You must be signed in to change notification settings - Fork 293
Migrate to prior module from pymc-extras #1767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
- Coverage 92.07% 91.78% -0.30%
==========================================
Files 62 62
Lines 7398 7025 -373
==========================================
- Hits 6812 6448 -364
+ Misses 586 577 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks great, but some tests are failing . . . |
Dropping support for python 3.10 ... |
TODO :
|
I've done some explicit deprecation warnings upon initialization of the public objects if imported from pymc_marketing.prior. I fear running into the issue like with #1540 if trying to raise upon import Let me know if this is sufficient. CC: @daniel-saunders-phil @juanitorduz |
Shall we add depreciation warnings in 0.15 and remove it entirely in 0.16 ? (or is this already what will happen?) |
We should also update the dev environment.yml, though maybe not in this PR. Minimum dependency requirements are out of sync with the library. |
There are deprecation warning with this PR. They will be removed in future release resulting in attribute errors |
I have also seen people use pymc-marketing in Databricks clusters with python 3.10 :/ . I wonder if this will have an impact in a lot of users. |
Likely. We should do minor release and put top of release notes |
Description
Adding the dependency of pymc-extras to use the prior module from there
Related Issue
Checklist
pre-commit.ci autofix
to auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1767.org.readthedocs.build/en/1767/