Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate several pymc_marketing.mmm.utils functions #1078

Merged

Conversation

PabloRoque
Copy link
Contributor

@PabloRoque PabloRoque commented Oct 7, 2024

Delete various pymc_marketing.mmm.utils functions associated with mentes and sigmoid transformations

Description

  • Delete:
    • estimate_menten_parameters
    • estimate_sigmoid_parameters
    • compute_sigmoid_second_derivative
    • find_sigmoid_inflection_point
  • Delete associated tests

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1078.org.readthedocs.build/en/1078/

@wd60622 wd60622 added the MMM label Oct 7, 2024
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I love these PRs!

@juanitorduz juanitorduz merged commit 95bc1fa into pymc-labs:main Oct 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate various pymc_marketing.mmm.utils functions
3 participants