#1063 Pareto_nbd distribution enhancements

[Ishaanjolly]

Distribution new customer enhancements

Description

I added n_samples: int = 1000 to _distribution_new_customers and modified this line within:

        if dataset.sizes["chain"] == 1 and dataset.sizes["draw"] == 1:
            # For map fit add a dummy draw dimension
            dataset = dataset.squeeze("draw").expand_dims(draw=range(n_samples))

Additionally:
I added n_samples: int = 1 to distribution_new_customer_recency_frequency and modified this:

self._distribution_new_customers(
            data=data,
            T=T,
            random_seed=random_seed,
            var_names=["recency_frequency"],
            n_samples=n_samples,
        )["recency_frequency"]

Related Issue

• Closes #
• Related to Repeat #1020 for pareto_nbd #1063

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Modules affected

• MMM
• CLV

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pymc-marketing--1067.org.readthedocs.build/en/1067/

[Ishaanjolly]

had to do this again as not updated the branch!

[juanitorduz]

Thanks @Ishaanjolly !

We need to fix one test that is failing

 tests/clv/models/test_pareto_nbd.py::TestParetoNBDModel::test_posterior_distributions[map] - assert (1, 1, 2357, 2) == (1, 1000, 2357, 2)

Let me know if you need help this that :)

[Ishaanjolly]

Thanks @Ishaanjolly !

We need to fix one test that is failing

 tests/clv/models/test_pareto_nbd.py::TestParetoNBDModel::test_posterior_distributions[map] - assert (1, 1, 2357, 2) == (1, 1000, 2357, 2)

Let me know if you need help this that :)

I had set n_samples = 1 in the _distribution_new_customers_frequency method without looking at the requirement.. think it's good now!

[ColtAllen]

Have you checked the Pareto/NBD notebook to make sure no changes need to be made?

[juanitorduz]

Have you checked the Pareto/NBD notebook to make sure no changes need to be made?

The notebooks are running on the CI so everything looks good :)

[juanitorduz]

Defaults to 1_000 right?

[Ishaanjolly]

1000, yeah sorry missed it. will correct it.

[Ishaanjolly]

done!

[juanitorduz]

Thanks @Ishaanjolly !