Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute Sampling: [] stdout when calling get_channel_contributions_forward_pass_grid #1043

Conversation

PabloRoque
Copy link
Contributor

@PabloRoque PabloRoque commented Sep 17, 2024

Mutes repetitive Sampling: [] message displayed when calling plot_channel_contributions_grid

Description

  • Adds disable_logger_stdout flag, an Optional[bool], to channel_contributions_forward_pass.
  • When True, it disables the pymc.sampling.forward logger propagation [as suggested here]
  • In essence we are muting stdout from this logger.info message

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1043.org.readthedocs.build/en/1043/

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thanks for looking into this!

@juanitorduz juanitorduz merged commit d0070ca into pymc-labs:main Sep 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Sampling: []" with plot_channel_contributions_grid method
2 participants