Skip to content

Minibatch warning fix #7749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Conversation

zaxtax
Copy link
Contributor

@zaxtax zaxtax commented Apr 3, 2025

Description

This fixes a small oversight in #7742 where it didn't check all ancestors to an observed value if it contains a MinibatchOp

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7749.org.readthedocs.build/en/7749/

@zaxtax zaxtax requested a review from ricardoV94 April 3, 2025 21:13
@zaxtax zaxtax force-pushed the minibatch_warning_fix branch from fa346f4 to 556a6e2 Compare April 3, 2025 21:44
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (4185b7b) to head (e955f44).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7749      +/-   ##
==========================================
- Coverage   92.82%   92.82%   -0.01%     
==========================================
  Files         107      107              
  Lines       18326    18325       -1     
==========================================
- Hits        17011    17010       -1     
  Misses       1315     1315              
Files with missing lines Coverage Δ
pymc/model/core.py 93.02% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 added maintenance no releasenotes Skipped in automatic release notes generation labels Apr 4, 2025
@ricardoV94 ricardoV94 merged commit 19389fc into pymc-devs:main Apr 4, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants