Allow censoring Categorical distributions #7662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7662 +/- ##
==========================================
- Coverage 92.78% 92.71% -0.08%
==========================================
Files 107 107
Lines 18196 18400 +204
==========================================
+ Hits 16884 17059 +175
- Misses 1312 1341 +29
|
| res = pt.switch( | ||
| def logp(value, p): | ||
| k = pt.shape(p)[-1] | ||
| value, safe_value_p = Categorical._safe_index_value_p(value, p) |
There was a problem hiding this comment.
I don't love making _safe_index_value_p a method. What's the conceptual advantage vs just being a function?
There was a problem hiding this comment.
doesn't clutter the namespace, that's the only difference
I did... it's in the Censored. Since there is no Categorical scipy distribution, I would just be comparing two implementations written by me? |
|
Ah, I tested the logp... hmm okay okay |
ricardoV94
force-pushed
the
censored_cat
branch
from
a3cbfee to
60c763f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported missing functionality in https://discourse.pymc.io/t/how-to-setup-a-censored-orderedlogistic-model/16451
📚 Documentation preview 📚: https://pymc--7662.org.readthedocs.build/en/7662/