Replaced "log-likelihood" with "distribution" in for all the classes where distributions is more appropriate rather than log-likelihood. #7573
Conversation
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including cdf, mean, and random methods.
|
|
|
Hi @tanishy7777 the idea is to change all the cases where this happened, not just MvNormal |
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance.
|
I've implemented the changes as per your suggestions in the latest commit. Apologies for the delayed response my end-semester exams were going on. @ricardoV94 |
|
Does this happen only in multivariate.py? |
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance, etc.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood including log-cdf, log-pdf.
|
Oh ok, will make the necessary changes. I think only the pymc/distributions folder has the files where the changes need to be made right? |
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance and covariance.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality.
|
I have updated all the files that need to be changes in the pymc/distributions folder. Please let me know if any other changes need to be made or if anything needs to be modified @ricardoV94 @twiecki |
|
Hi, I noticed that PR #7573 has been inactive for 5 months. Is this issue still open for contribution? If the original contributor is unavailable, I’d love to work on it! |
Hey, I think I have already made all of the changes required by this issue. But please go ahead if you find any more places where the changes need to be made. From my end the PR is done. I was waiting for the approval from the maintainers. |
|
@ricardoV94 @twiecki Just wanted to remind you about this PR. Please have a look at it at your convenience. |
twiecki
changed the title
|
|
|
Thanks! |
Replaced "log-likelihood" with "distribution" in for all the classes where distributions is more appropriate rather than log-likelihood.
Description
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance and covariance.
Related Issue
x log-likelihood#7563Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7573.org.readthedocs.build/en/7573/