Refactor and deprecate resolving of interface implementations in pyreverse
#6713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudeNr33
added
pyreverse
Pull Request Test Coverage Report for Build 2397637286
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
May 27, 2022
Comment on lines
+386
to
+388
| * ``pyreverse``: Resolving and displaying implemented interfaces that are defined by the ``__implements__`` | ||
| attribute has been deprecated and will be removed in 3.0. | ||
|
|
| warnings.warn( | ||
| "pyreverse will drop support for resolving and displaying implemented interfaces in pylint 3.0. " | ||
| "The implementation relies on the '__implements__' attribute proposed in PEP 245, which was rejected " | ||
| "in 2006.", |
There was a problem hiding this comment.
Wow, 2006 😄 I was copy pasting javascript and basic for high school calculator at the time.
Co-authored-by: Pierre Sassoulas <[email protected]>
…eNr33/pylint into refactor-pyreverse-inspector
DudeNr33
commented
May 27, 2022
Comment on lines
-284
to
-287
| * ``pylint.pyreverse.ASTWalker`` has been removed, as it was only used internally by a single child class. | ||
|
|
||
| Ref #6712 | ||
|
|
There was a problem hiding this comment.
This is now under "Deprecations" in order to be grouped with #6713, although this is technically not a deprecation but a hard removal. Let me know if that's OK for you to put it there.
DudeNr33
commented
May 27, 2022
| @@ -110,7 +110,7 @@ class Concrete23(Concrete1): pass | |||
| ("Concrete0", ["MyIFace"]), | |||
| ("Concrete1", ["MyIFace", "AnotherIFace"]), | |||
| ("Concrete2", ["MyIFace", "AnotherIFace"]), | |||
| ("Concrete23", ["MyIFace", "AnotherIFace"]), | |||
There was a problem hiding this comment.
The reason this test changed is that the unit test actually used the default value of True for the now removed herited parameter, but in production this parameter was always False. So after removing the parameter from the function signature I had to update this test case accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
Ref #6582
As we also deprecated the use of
__implements__in our own codebase, deprecating thepyreversefunctionality to resolve and display implemented interfaces is the right consequence.To make this change transparent for users, a
DeprecationWarningwill be issued when such an__implements__attribute has been found.Additionally, I removed parameters and checks that were always constant in production use of the code.