Add generated rst in the documentation for easier review #6678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
force-pushed
the
add-generated-rst
branch
from
8529052 to
22be27d
Compare
Pull Request Test Coverage Report for Build 2373703840
💛 - Coveralls |
Pierre-Sassoulas
force-pushed
the
add-generated-rst
branch
from
22be27d to
9c44ab7
Compare
DanielNoord
reviewed
May 24, 2022
| @@ -110,7 +109,9 @@ def _create_checker_section( | |||
| checker_table.add(tomlkit.nl()) | |||
|
|
|||
| pylint_tool_table.add(options[0].checker.name.lower(), checker_table) | |||
| toml_string = "\n".join(f" {i}" for i in tomlkit.dumps(toml_doc).split("\n")) | |||
| toml_string = "\n".join( | |||
| f" {i}" if i else "" for i in tomlkit.dumps(toml_doc).split("\n") | |||
There was a problem hiding this comment.
Does this fix something in particular?
There was a problem hiding this comment.
It removes trailing whitespaces in the generated result (Check the commit by commit view to understand this kind of fix better)
DanielNoord
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
It's a lot harder to check everything when you need to compare two HTMLs side by side instead, of a a git diff on .rst code then check the modified HTML visually. Relates to #6665