Skip to content

Subclass BaseRawFileChecker and BaseTokenChecker #6395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

Subclass BaseRawFileChecker and BaseTokenChecker #6395

merged 1 commit into from
Apr 19, 2022

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Apr 19, 2022 •
edited
Loading

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Ref. #2287

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Apr 19, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 19, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2191999873

  • 20 of 20 (100.0%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 95.158%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/base_checker.py 1 88.89%
Totals Coverage Status
Change from base Build 2191969304: -0.009%
Covered Lines: 15782
Relevant Lines: 16585
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the how to implement a checker doc should be updated a little, right ?

@DanielNoord
Copy link
Collaborator Author

I think the how to implement a checker doc should be updated a little, right ?

I'll do a check for any interfaces.... code/text after the DeprecationWarning gets emitted. Only two/three PRs remain for this to be done.

Perhaps wait with the 2.14 pre-release and get this as well? Should be able to finish this tonight/tomorrow?

@Pierre-Sassoulas
Copy link
Member

Yeah I'm too sleepy to release anything right now anyway 😄

@DanielNoord DanielNoord merged commit 6b25ff0 into pylint-dev:main Apr 19, 2022
@DanielNoord DanielNoord deleted the implements-4 branch April 19, 2022 21:06
@Pierre-Sassoulas
Copy link
Member

Also I need to create a namespace test repository for #5235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas