Fix handling of "for x in x" homonyms #6154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Needs backport
Pull Request Test Coverage Report for Build 2085389935
💛 - Coveralls |
jacobtylerwalls
commented
Apr 3, 2022
| my_int: int # [unused-variable] | ||
| my_int: int |
Pierre-Sassoulas
added
the
False Positive 🦟
Co-authored-by: Pierre Sassoulas <[email protected]>
Pierre-Sassoulas
added a commit
that referenced
this pull request
Apr 4, 2022
Co-authored-by: Pierre Sassoulas <[email protected]>
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #6136
Extends the fix from #6073. (There, I had to be careful to not emit
unused-argument, since that's all the test suite alerted me to, but with diffing primer output locally, I noticed the same deal withunused-variable. So I handle that the same way.)