-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add another docstring formatter in pre-commit #5629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 1647217961
π - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good ! Would you mind checking the updated #5624 ? I removed docformatter and applied pydocstringformatter. I've done some (hundreds π) manual fixes here, I'd like them to be added if possible. But I think there's some case where pydocstringformatter do not fix some issue see https://github.com/PyCQA/pylint/pull/5624/files#diff-35d3c5349e5876e9820da739cbefc979ef433a55ab338df84cae9e2cd1b0d0c2R6 for example.
I fixed the issue with module docstrings not getting recognised. I have got some other things I would like to put in |
To be noted that when we add it's going to be independent, there will be a an automatic upgrade if you release a version of Also maybe a cool name would be nice ? π It's similar to black so something with color ? It's a shame that 257 is too high for RGB and PEP too high for hex code, but #FEF257 is close enough and is a light yellow, so maybe |
Indeed! I think the current
I'm open to good suggestions, I think |
(Chanteclerc is a variety of yellow apples.) Though I realized that basically every pep would be very close in color to each other with this 'pep to hex' reasoning. Another possibility is checking what happened in 257 (a lot had to do with Valerian, which sounds Nice) or 257 bc (Tyndaris, sounds nice too). https://en.m.wikipedia.org/wiki/257_BC. |
@Pierre-Sassoulas Updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's pretty nice π
Type of Changes
Description
@Pierre-Sassoulas Just to show off the new program I wrote. It is somewhat nitpicky, but would save time in review. Repository can be found here.
Let me know if this is something you would want to merge or if anything is missing!