Skip to content

Bump CI cache version #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2021
Merged

Bump CI cache version #5602

merged 1 commit into from
Dec 27, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Dec 27, 2021

Description

Bump the cache version. Will fix the CI issues seen in #5600 where it could create the venv.

@cdce8p cdce8p added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 27, 2021
@cdce8p cdce8p added this to the 2.13.0 milestone Dec 27, 2021
@cdce8p cdce8p mentioned this pull request Dec 27, 2021
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1628108228

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.708%
Totals Coverage Status
Change from base Build 1626514219: 0.0%
Covered Lines: 14312
Relevant Lines: 15273
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're lucky, no issue with github actions 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 691b41b into pylint-dev:main Dec 27, 2021
@cdce8p cdce8p deleted the fix-ci branch December 27, 2021 20:05
@cdce8p cdce8p mentioned this pull request Dec 27, 2021
Merged
@cdce8p
Copy link
Member Author

cdce8p commented Dec 27, 2021

You're lucky, no issue with github actions 😄

Define lucky 😅
Took me a while to figure out that this was enough to fix it. Had the same issue on one of my personal repos.

@DanielNoord
Copy link
Collaborator

@cdce8p For future reference, we also store CACHE_VERSION in the primer workflow. I'm adding a commit + comments that they should be changed in both places.

@DanielNoord DanielNoord mentioned this pull request Dec 30, 2021
Merged
2 tasks
@cdce8p
Copy link
Member Author

cdce8p commented Jan 1, 2022

Found a Python bug report that looks like the root cause for our issues: https://bugs.python.org/issue46197

@DanielNoord
Copy link
Collaborator

@cdce8p Good catch! That indeed seems to eb the culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cdce8p @coveralls @DanielNoord @Pierre-Sassoulas