Skip to content

Revert renaming extension tests #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2021
Merged

Revert renaming extension tests #5473

merged 3 commits into from
Dec 5, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Dec 5, 2021

Description

Revert parts of #5374

The test file names for the code_style and typing extensions where intentionally prefixed to allow for easier testing.

pytest tests/test_functional -k typing
pytest tests/test_functional -k cs

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1540289752

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.694%
Totals Coverage Status
Change from base Build 1538983394: 0.0%
Covered Lines: 14160
Relevant Lines: 15113
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought that the file path was taken into account when using -k, It's not the case anymore as we're using the name and not the file path when parametrizing. Good job on separating python 3.5 / 3.8 too !

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Dec 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit 7873b77 into pylint-dev:main Dec 5, 2021
@cdce8p cdce8p deleted the rename-extension-tests branch December 5, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @coveralls @Pierre-Sassoulas