-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try new branch of astroid
to see if change works
#10152
Closed
Closed
+4
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
force-pushed
the
collections-fix
branch
from
December 23, 2024 21:19
6f9a3b3
to
253ea65
Compare
@jacobtylerwalls Can you test pylint-dev/astroid#2665? At least the |
DanielNoord
force-pushed
the
collections-fix
branch
from
December 23, 2024 22:18
f23d897
to
4943ebc
Compare
This comment has been minimized.
This comment has been minimized.
@jacobtylerwalls Primer seems very positive? Or am I misreading it? I'll clear the Action caches and rerun everything, but I'm hopeful my last changes actually work. |
DanielNoord
force-pushed
the
collections-fix
branch
from
December 23, 2024 22:44
4943ebc
to
dd0fd9c
Compare
DanielNoord
changed the title
WIP try new branch for
Try new branch of Dec 23, 2024
astroid
astroid
to see if change works
Thanks @DanielNoord ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try pylint-dev/astroid#2665 and see if it works.
It seemingly does?
I have removed one test that was added in 255562a. I don't really see why it is needed (it clearly isn't a move, but a new test...). With the change for
collections.abc
it should now be_collections_abc
. Anyway,xml.etree.
seems to do the same?