Fix used-before-assignment false negative for nonlocals
#10075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenlyj
commented
Nov 9, 2024
zenlyj
force-pushed
the
fix/10069-nonlocal-uba
branch
from
5b626da to
a7c28bd
Compare
|
we should probably skip changelog for this one? as it is more of an internal update |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10075 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18959 18962 +3
=======================================
+ Hits 18163 18166 +3
Misses 796 796
|
zenlyj
force-pushed
the
fix/10069-nonlocal-uba
branch
from
a7c28bd to
f347162
Compare
This comment has been minimized.
This comment has been minimized.
zenlyj
force-pushed
the
fix/10069-nonlocal-uba
branch
from
f347162 to
db56fc9
Compare
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit db56fc9 |
jacobtylerwalls
added
the
Skip news π
jacobtylerwalls
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
A continuation of #10034. This PR addresses the case where a nonlocal declaration exists outside the immediate enclosing frame for both the usage and definition.
Changes primarily extend the check for nonlocal declarations so that it stops once it reaches the first enclosing frame, ensuring that it does not go beyond the initial enclosing frame.
Closes #10069