Pick correct file if two files with the same name but with different extensions exist

[Chasarr]

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs

Description

To replicate the error that this PR fixes, you need to create two files:

test.py    # Contains Pylint errors
test.py2   # Does not contain Pylint errors

and then I run pylint test.py2 it reports Pylint errors from test.py. (the wrong file)

I believe this was due to a typo/logical error. Before this PR, I don't think the prefer_stubs argument even did anything.

Closes pylint-dev/pylint#3631

[Chasarr]

Hmm, the CI isn't too happy. Investigating...

[Chasarr]

All tests pass on my machine now, so it should work

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (ce81c29) to head (e278288).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2722   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          93       93           
  Lines       11071    11072    +1     
=======================================
+ Hits        10320    10321    +1     
  Misses        751      751           

Flag	Coverage Δ
linux	93.08% <100.00%> (+<0.01%)	⬆️
pypy	93.21% <100.00%> (+<0.01%)	⬆️
windows	93.19% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
astroid/modutils.py	89.51% <100.00%> (+0.03%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Chasarr]

I don't think automatic issue closing works between repos, so someone with the correct permissions needs to close it manually.

[Pierre-Sassoulas]

Thank you for the fix @Chasarr, do you mind adding some automated tests please ?

[Chasarr]

Done :)

[Pierre-Sassoulas]

Thank you for the automated tests, it looks great. Do you mind adding a changelog entry too ? You probably need to specify that the issue you're closing come from pylint, like this:

astroid/ChangeLog

Line 52 in df10777

Closes pylint-dev/pylint#8589

And if you want to have an aliase for the contributors list you can do it in https://github.com/pylint-dev/astroid/blob/main/script/.contributors_aliases.json#L4

[Chasarr]

Done! Thanks for the guidance!

[DanielNoord]

@Pierre-Sassoulas Are you able to review this? Before it goes stale 😄

[github-actions]

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2722-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f52268d03c0d19d869d830444f500c154d8a74e5
# Push it to GitHub
git push --set-upstream origin backport-2722-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-2722-to-maintenance/3.3.x.

[Pierre-Sassoulas]

Sorry for the delay, thank you for the PR, congrats on becoming a contributor :)

[Chasarr]

Thank you, this is the first piece of code to a big open source project I have contributed to! Feels good!

[Chasarr]

Should I do anything to backport the commit to 3.3.X? Or do you do that?

[Pierre-Sassoulas]

Don't worry I'm going to do it :)