fix default_value for kwonlyargs with no default #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs pylint-dev#2213. Requesting the default value for a kwonlyarg with no default would fail with an IndexError, it now correctly raises a NoDefault exception. This issue arised after changes in PR pylint-dev#2240.
crazybolillo
force-pushed
the
post-2240-crazybolillo
branch
from
5b5dc4b to
2ff25cb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 94 94
Lines 10949 10951 +2
=======================================
+ Hits 10159 10161 +2
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
approved these changes
Jul 22, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2213.
Requesting the default value for a kwonlyarg with no default would fail with an IndexError, it now correctly raises a NoDefault exception. This issue arised after changes in PR #2240.