Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Import annotations for 3.9 compatibility with type hint sugar #24

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

liamhuber
Copy link
Member

@liamhuber liamhuber commented Jul 22, 2024

Closes #23

(At least it should. python not-3.12 tests are not actually being run so we'll get final confirmation in the PR that updates the CI version to fix this. For now I will close the issue on merge in faith.)

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_snippets/future_annotations

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7a4fe2a) 550 522 94.91%
Head commit (7e95ea6) 551 (+1) 523 (+1) 94.92% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10044840709

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 94.918%

Files with Coverage Reduction New Missed Lines %
resources.py 4 96.0%
Totals Coverage Status
Change from base Build 9941886607: 0.009%
Covered Lines: 523
Relevant Lines: 551

💛 - Coveralls

@liamhuber liamhuber merged commit caa505a into main Jul 22, 2024
20 checks passed
@liamhuber liamhuber deleted the future_annotations branch July 22, 2024 16:41
@jan-janssen
Copy link
Member

I guess it makes sense to pus this patch also to conda.

@liamhuber
Copy link
Member Author

Yes, but I want to wait until the CI is also fixed and updated. I'm working on that now and expect to fix it today, so the delay should not be large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using vertical bar "|" for unions makes the package incompatible to python < 3.10 but 3.9 is still listed
3 participants