-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test docs examples #35
Conversation
To better reflect purpose
Particularly for the README examples test, which explicitly imports `pyiron_atomistics.Project`
Tabs are screwing up the example test
We don't want to compare against that
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
On windows:
Riiight. The |
So we can get pyiron_atomistics for the README docs example, but save lammps (unavailable on windows) for just the notebooks
Doc test is failing, but it looks at first glance like the problem is up-stream:
Installed versions in that stack:
|
Yeah, |
The latest version of mp-api (0.39.5) puts a hard lower limit of 0.57.1, so I guess this is pyiron's fault for permitting older versions of mp-api when their dependency control was suckier. |
To get a version of mp-api that handles its dependencies well.
Rename the "notebooks" env more properly to reflect it is just pyiron_atomistics, and it is used for both docs and notebooks. Then format the README examples for doctest and test them.