-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .content rather than .project_hdf5 #1509
Conversation
This allows .output to work with Sphinx jobs that use strange output format.
Does this break LAMMPS and VASP? |
Catch KeyError as well as ValueError. Previously we used project_hdf5 to access the storage in GenericOutput, which raises ValueError on missing keys. Now using content we have to check KeyError as well, as that is raised by HDF5Content.
Pull Request Test Coverage Report for Build 10143456330Details
💛 - Coveralls |
The only difference between .content and .project_hdf5 is that the former tries to @samwaseda Can you add a test case for #1508? |
@pmrv Should we adjust the pyiron table to also use |
You mean the predefined datamining functions? Yes, that would make sense. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Once @samwaseda confirms it fixes his issues, I guess we should merge this and a release a new minor version.
@samwaseda Can you confirm this is working for SPHInx? I would like to release a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's fine.
This allows .output to work with Sphinx jobs that use strange output format.