Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename output parameter to output_keys #180

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Rename output parameter to output_keys #180

merged 6 commits into from
Jan 8, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jan 8, 2024

To be more explicit the parameter output is renamed to output_keys. Previously this change was included in #176 - now it is separated in a separate pull request.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

# Conflicts:
#	atomistics/workflows/elastic/workflow.py
#	atomistics/workflows/evcurve/workflow.py
#	atomistics/workflows/quasiharmonic.py
@jan-janssen jan-janssen added the format_black Launch the pyiron/actions black formatting routine label Jan 8, 2024
@jan-janssen jan-janssen requested a review from liamhuber January 8, 2024 17:12
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, that's a slightly better name.

@jan-janssen jan-janssen merged commit c02d8d9 into main Jan 8, 2024
19 checks passed
@jan-janssen jan-janssen deleted the outputkeys branch January 9, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black Launch the pyiron/actions black formatting routine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants