-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mask SDL3 #3307
Mask SDL3 #3307
Conversation
9389b97
to
0f86a91
Compare
Co-Authored-By: Ankith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR! Left a few more minor reviews, but this PR should be good to go in after those reviews are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, LGTM. Changes make sense - especially now we've seen these sorts of pixel format changes a few times now. It all compiles and runs the tests fine locally as well 👍
Today I ported a few modules and worked on a few others.
I first did everything with explicit SDL2 vs SDL3 code to observe patterns, then I made a few new compatibility macros to match what I saw.
This PR is those macros + the mask module.