Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask SDL3 #3307

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Mask SDL3 #3307

merged 2 commits into from
Jan 26, 2025

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Jan 26, 2025

Today I ported a few modules and worked on a few others.

I first did everything with explicit SDL2 vs SDL3 code to observe patterns, then I made a few new compatibility macros to match what I saw.

This PR is those macros + the mask module.

@Starbuck5 Starbuck5 added mask pygame.mask sdl3 labels Jan 26, 2025
@Starbuck5 Starbuck5 requested a review from a team as a code owner January 26, 2025 09:18
src_c/_pygame.h Outdated Show resolved Hide resolved
src_c/_pygame.h Show resolved Hide resolved
@Starbuck5 Starbuck5 force-pushed the mask-sdl3 branch 2 times, most recently from 9389b97 to 0f86a91 Compare January 26, 2025 09:48
src_c/mask.c Outdated Show resolved Hide resolved
src_c/mask.c Outdated Show resolved Hide resolved
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! Left a few more minor reviews, but this PR should be good to go in after those reviews are addressed.

src_c/mask.c Outdated Show resolved Hide resolved
src_c/mask.c Outdated Show resolved Hide resolved
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM. Changes make sense - especially now we've seen these sorts of pixel format changes a few times now. It all compiles and runs the tests fine locally as well 👍

@Starbuck5 Starbuck5 merged commit de6a74d into pygame-community:main Jan 26, 2025
24 of 25 checks passed
@Starbuck5 Starbuck5 added this to the 2.5.3 milestone Jan 26, 2025
@Starbuck5 Starbuck5 deleted the mask-sdl3 branch January 26, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mask pygame.mask sdl3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants