Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TestTags so it doesn't get confused for a test #3276

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Rename TestTags so it doesn't get confused for a test #3276

merged 1 commit into from
Dec 30, 2024

Conversation

MyreMylar
Copy link
Member

Noticed this warning in the console:

test\test_utils\test_machinery.py:47
  C:\Users\dan\Programming\pygame-ce\test\test_utils\test_machinery.py:47: PytestCollectionWarning: cannot collect test class 'TestTags' because it has a __init__ constructor (from: test/test_utils/test_machinery.py)
    class TestTags:

The class name starting with Test is confusing the testing machinery that looks for tests in the tests folder. Seems a simple enough fix to rename the class slightly so it doesn't begin with Test.

@MyreMylar MyreMylar requested a review from a team as a code owner December 30, 2024 16:11
damusss
damusss approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM :)
(the failing test should get fixed by your latest pr)

ankith26
ankith26 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@ankith26 ankith26 merged commit 1b89e60 into main Dec 30, 2024
23 of 24 checks passed
@ankith26 ankith26 deleted the rename-test-tags branch December 30, 2024 18:53
@ankith26 ankith26 added this to the 2.5.3 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@MyreMylar @ankith26 @damusss