Fix *most of* the Deprecation Warnings in surfarray_test #3274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that there were several fixable Deprecation Warnings coming out of our surfarray tests.
I feel in general that we should try and minimise the outputting of 'expected' warnings from our tests so that we are more likely to find the unexpected ones when running a full test run.
I spotted the warnings by running:
There are two main fixes applied:
as a context manager when we are deliberately calling a deprecated function at the moment - we can remove tests like this if/when the deprecated function itself is finally removed.