Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDL2_image to 2.8.3 #3271

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Bump SDL2_image to 2.8.3 #3271

merged 1 commit into from
Dec 27, 2024

Conversation

ankith26
Copy link
Member

fixes #3036

@ankith26 ankith26 requested a review from a team as a code owner December 18, 2024 06:05
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed again it fixes the linked issue as expected.

Thanks!

P.S. I'm quite pleased you were able to use the SDL_image fork to generate a new Windows prebuilt.

@ankith26
Copy link
Member Author

Yeah well thanks to the CI you already setup, it wasn't hard to do it :)

@Starbuck5
Copy link
Member

I'm glad. It's just something I thought I had expected I would need to do myself.

Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Does appear to fix the linked issue too

P.S. it was very painful getting pygame-ce to compile with these changed dependencies, maybe we should streamline this? Because the wiki mentions installing development dependencies from package repositories, however, in this case, they have to be got directly from the SDL repo. I'd propose adjusting, for example, buildconfig/manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh so that it can be used locally.

@Matiiss Matiiss merged commit a8c2997 into main Dec 27, 2024
24 checks passed
@ankith26 ankith26 deleted the ankith26-bump-SDL2_image branch December 27, 2024 08:50
@ankith26
Copy link
Member Author

The best way to test this PR would be to simply download the wheels generated by CI, that is what I also did.

I think generalizing the docker scripts is more effort than it is useful, due to the fact that we pick some settings specifically for the purpose of bundling the dependencies in wheels, you would not want those settings used in your local SDL install.

@ankith26 ankith26 added this to the 2.5.3 milestone Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain PNGs load incorrectly.
4 participants