-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RLE usage in the transform module #2535
Conversation
Co-authored-by: Joras <[email protected]> Co-authored-by: Antonio <[email protected]> Co-authored-by: João <[email protected]> Co-authored-by: Caio <[email protected]> Co-authored-by: Cícero <[email protected]> Co-authored-by: Natália <[email protected]>
function was added in 2.0.14 - min SDL version currently 2.0.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also a simple test case for this would be nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR! 🎉
(Needs a run of black on the test file to make the linter happy however)
PS: To the person merging this, please squash and merge (and remove any incorrect co-author tags too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Building on work done in #2491. Don't merge this until that has gone in.
This makes sure we don't add the RLE flag to surfaces that didn't already have it before they were transformed. This was breaking output after transforms on color key surfaces - and there is no reason for us to be doing it.
fixes #1668