display.message_box()

[yunline]

As a replacement of video.messagebox().

Examples:

pygame.display.message_box("Hello")

pygame.display.message_box(
    "Hello",
    "Hello pygame-ce",
    type = "warn"
)

result = pygame.display.message_box(
    "Error",
    "V我50",
    type="error",
    buttons=("Wednesday", "Thursday", "Friday"),
    return_button = 1,
    escape_button = None
)

print(result)

[MyreMylar]

Should we take the opportunity of this function moving modules (from a dead module) to rename it from messagebox() to message_box() which is more in the PEP8 style?

[Matiiss]

Should we have some constants for the modes too?
For example
pygame.MESSAGE_BOX_INFO or pygame.display.MESSAGE_BOX_INFO (or MESSAGEBOX_...) or something of the like that would simply represent those strings.

[zoldalma999]

Should this be added in system instead of display? I think it would make sense there, especially since SDL3 will (probably) have support for (save, open file, open folder) file dialogs as well.

[Starbuck5]

Should this be added in system instead of display? I think it would make sense there, especially since SDL3 will (probably) have support for (save, open file, open folder) file dialogs as well.

I've supported having this in display in the past. Good point about SDL file dialogs though (libsdl-org/SDL#7445). They have a full implementation waiting in a PR.

In the SDL implementation, the messagebox and file dialog systems are very separate: different API styles, different modules. Hence it will be okay for us to have messagebox in pygame.display and file dialogs in pygame.system.

[Starbuck5]

Alright, lets pull this in. I couldn't find anything wrong in testing.

Thanks for moving this forward!

Eventually it would be nice to have _sdl2.video.messagebox be a compat shim over this API, but that's for another pull request.

[ankith26]

LGTM, thanks for the PR 🎉

Left two reviews that are nice-to-haves

[Starbuck5]

@yunline I'm not sure why circleci is failing for you, maybe a rebase against main would fix it?

This looks ready to merge, I left a tiny wording note and this needs to be squashed down to fewer commits before merging.

[pmp-p]

That seems like a blocking function, it is really necessary to add things that cannot be ported on some platforms ?

i mean was really video.messagebox used anyway ?